Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

There was a legacy issue where we combined abort download event and progress event into 1 pipeline.

Download: +------A1-------A2--------A3---X
Cancel : +---B1-----B2-------B3---------X

Problems:

  1. We use a throttle without trailing event emission.
  • At X, there is no A3 event emitted (e.g., 100% or success event).
  1. We add a trailing event emission.
  • At A2, we abort the download process -> a B1 event is emitted, then A2 once (aborted -> downloading).

Fixes Issues

  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai self-requested a review July 19, 2024 03:15
@louis-jan louis-jan merged commit 10bfad2 into dev Jul 19, 2024
@louis-jan louis-jan deleted the fix/download-model-api-wrong-event-emit branch July 19, 2024 03:16
@louis-jan louis-jan changed the title fix: download model wrong event mits fix: download model wrong event emission Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants