Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@marknguyen1302
Copy link
Contributor

Describe Your Changes

  • correct progress multi download

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@marknguyen1302 marknguyen1302 requested a review from louis-jan July 29, 2024 08:05
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marknguyen1302 marknguyen1302 merged commit dca44cd into dev Jul 29, 2024
@marknguyen1302 marknguyen1302 deleted the fix/correct-progress-multi-download branch July 29, 2024 08:45
if (stream.length) {
const data = stream[0] as any;
if (downloadId && data.id !== downloadId || downloadType && data.type !== downloadType) continue;
const data = (stream.find((data: any) => data.id === downloadId || !downloadId) as DownloadState | undefined);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitwise operator?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants