Initiate docker compose for keycloak#3
Merged
Merged
Conversation
freelerobot
reviewed
Aug 22, 2023
| @@ -0,0 +1,2 @@ | |||
| .vscode | |||
| .env No newline at end of file | |||
Contributor
There was a problem hiding this comment.
can you add a .env.sample? and add the secrets to 1pass? ty!
Contributor
Author
There was a problem hiding this comment.
I will add an .env.sample file. All of these are for locally so I don't think we need to update them to 1password
freelerobot
reviewed
Aug 22, 2023
| environment: | ||
| KEYCLOAK_URL: http://keycloak:8080 | ||
| KEYCLOAK_USER: ${KEYCLOAK_ADMIN-admin} | ||
| KEYCLOAK_PASSWORD: ${KEYCLOAK_ADMIN_PASSWORD-admin} |
Contributor
There was a problem hiding this comment.
What's with the uppercase then lower case, and _ then -?
Is it intentional?
Contributor
Author
There was a problem hiding this comment.
Example with KEYCLOAK_USER: ${KEYCLOAK_ADMIN-admin}:
KEYCLOAK_USER will get the value of $KEYCLOAK_ADMIN environment variable if exists, else the value admin will be set
freelerobot
approved these changes
Aug 22, 2023
hiento09
force-pushed
the
feature/jan-1229
branch
from
805c9bd to
abfeb67
Compare
6 tasks
This was referenced Apr 7, 2026
This was referenced Apr 18, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the initiate docker compose for keycloak.
I will integrate the keycloak configuration with jan-web later.