Merged
Conversation
Collaborator
locnguyen1986
commented
Nov 14, 2025
locnguyen1986
commented
- Remove debug check
- Do not return id_token as kong redirect limit
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts logging levels for OAuth callback handlers and removes the id_token from redirect URLs to prevent Kong gateway rejections due to URL length limits.
- Changed OAuth callback logging from
InfotoDebuglevel throughout the handler - Commented out id_token inclusion in frontend redirect URLs to avoid Kong's redirect size limitations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if tokenResp.IDToken != "" { | ||
| fragment += fmt.Sprintf("&id_token=%s", url.QueryEscape(tokenResp.IDToken)) | ||
| } | ||
| // client don't need id_token, so we comment it out as kong rejects long redirect URLs |
There was a problem hiding this comment.
Grammar issue: "client don't need" should be "client doesn't need" or "clients don't need".
Suggested change
| // client don't need id_token, so we comment it out as kong rejects long redirect URLs | |
| // clients don't need id_token, so we comment it out as kong rejects long redirect URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.