Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR is titled as a typo fix but actually introduces changes that are inconsistent with that purpose. The changes add three exclamation marks to an error message and introduce trailing whitespace in a Makefile echo statement. Neither change addresses an actual typo.
- Modified an error message by adding excessive punctuation ("!!!")
- Added trailing whitespace to a Makefile echo statement
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/llm-api/internal/config/provider_configs.go | Error message modified with excessive exclamation marks |
| Makefile | Trailing whitespace added to configuration help text |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func LoadProviderBootstrapConfig(path string) (*ProviderBootstrapConfig, error) { | ||
| if strings.TrimSpace(path) == "" { | ||
| return nil, errors.New("provider config path is empty") | ||
| return nil, errors.New("provider config path is empty!!!") |
There was a problem hiding this comment.
Adding three exclamation marks to an error message is unconventional and unprofessional. Error messages should be clear and informative without excessive punctuation. Consider keeping the original format: "provider config path is empty" or at most using a single period for proper sentence structure.
| return nil, errors.New("provider config path is empty!!!") | |
| return nil, errors.New("provider config path is empty") |
| @echo " 2. Run 'make config-generate' to regenerate all files" | ||
| @echo " 3. Run 'make config-test' to verify changes" | ||
| @echo " 4. Use 'make config-drift-check' in CI to prevent drift" | ||
| @echo " 4. Use 'make config-drift-check' in CI to prevent drift " |
There was a problem hiding this comment.
Trailing whitespace has been added to this line. Trailing whitespace should be removed as it serves no purpose and can cause unnecessary diff noise in version control.
| @echo " 4. Use 'make config-drift-check' in CI to prevent drift " | |
| @echo " 4. Use 'make config-drift-check' in CI to prevent drift" |
fix typo