Prep double? for jank
#795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanu-sardesai
force-pushed
the
issues/415-double-qmark-port
branch
from
0be75b0 to
c91aac2
Compare
More context can be found [here](jank-lang/jank#583 (comment)).
shantanu-sardesai
force-pushed
the
issues/415-double-qmark-port
branch
from
c91aac2 to
63e60ee
Compare
jeaye
requested changes
Nov 17, 2025
Member
jeaye
left a comment
jeaye
left a comment
There was a problem hiding this comment.
I don't think we should have three copies of all of these tests. Two was already too much. Would you mind please instead refactoring all common tests outside of the reader conditional so we can have no duplication?
Reader conditionals are for edge cases.
Contributor
Author
|
Does this look better? |
Member
|
Yep, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context can be found here.