Skip to content

Prep double? for jank #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

Prep double? for jank #795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e60ee
Prep `double?` for `jank`
shantanu-sardesai Nov 10, 2025
591dd7f
Simplify common test cases
shantanu-sardesai Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions test/clojure/core_test/double_qmark.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,58 +6,58 @@
(when-var-exists clojure.core/double?
(deftest test-double?
(are [expected x] (= expected (double? x))
#?@(:cljs ; In CLJS, all numbers satisfy `double?`
[true 0
true 1
true -1
true r/max-int
true r/min-int
true 0.0
true 1.0
true -1.0
true (float 0.0) ; surprising since (float? (double 0.0)) = true
true (float 1.0) ; surprising since (float? (double 1.0)) = true
true (float -1.0) ; surprising since (float? (double -1.0)) = true
true (double 0.0)
true (double 1.0)
true (double -1.0)
true r/max-double
true r/min-double
true ##Inf
true ##-Inf
true ##NaN
true 0N
true 1N
true -1N
true 0.0M
true 1.0M
true -1.0M]
:default
[false 0
false 1
false -1
false r/max-int
false r/min-int
true 0.0
true 1.0
true -1.0
false (float 0.0) ; surprising since (float? (double 0.0)) = true
false (float 1.0) ; surprising since (float? (double 1.0)) = true
false (float -1.0) ; surprising since (float? (double -1.0)) = true
true (double 0.0)
true (double 1.0)
true (double -1.0)
true r/max-double
true r/min-double
true ##Inf
true ##-Inf
true ##NaN
false 0N
false 1N
false -1N
false 0.0M
false 1.0M
false -1.0M])
#?@(:cljs
[true 0
true 1
true -1
true r/max-int
true r/min-int]
:default
[false 0
false 1
false -1
false r/max-int
false r/min-int])
true 0.0
true 1.0
true -1.0
#?@(:jank
[;; Since currently jank doesn't support `float` (`jank::f32`) literal values only `double` (`jank::f64`)
;; literal values, there is no difference in the implementation of `float` and `double`.
true (float 0.0)
true (float 1.0)
true (float -1.0)]
:cljs
[true (float 0.0)
true (float 1.0)
true (float -1.0)]
:default
[false (float 0.0) ; surprising since (float? (double 0.0)) = true
false (float 1.0) ; surprising since (float? (double 1.0)) = true
false (float -1.0) ; surprising since (float? (double -1.0)) = true
])
true (double 0.0)
true (double 1.0)
true (double -1.0)
true r/max-double
true r/min-double
true ##Inf
true ##-Inf
true ##NaN
#?@(:cljs
[true 0N
true 1N
true -1N
true 0.0M
true 1.0M
true -1.0M]
:default
[false 0N
false 1N
false -1N
false 0.0M
false 1.0M
false -1.0M])
#?@(:cljs [] ; CLJS doesn't have ratios
:default
[false 0/2
Expand Down