Skip to content

Convert arr-common chart exportarr property to more generic metrics interface.#140

Merged
Matthew-Beckett merged 2 commits into
mainfrom
feature/arr-common-metrics-exporter
Apr 1, 2026
Merged

Convert arr-common chart exportarr property to more generic metrics interface.#140
Matthew-Beckett merged 2 commits into
mainfrom
feature/arr-common-metrics-exporter

Conversation

@Matthew-Beckett
Copy link
Copy Markdown
Contributor

@Matthew-Beckett Matthew-Beckett commented Mar 31, 2026

This PR serves as the ground work for the rest of the missing arr-stack adjacent applications such as qBittorrent which are not supported by Exportarr to still use arr-common for it's features, but have a more robust interface to push in custom configuration for their required exporter.

Updates to the arr-common Helm library chart to replace the previous exportarr metrics exporter configuration with a more flexible and extensible metrics configuration. The new approach allows for better customization of the metrics exporter container and its integration with the chart, including support for additional arguments, commands, environment variables, and resource settings.

Key changes include:

Metrics Exporter Refactor

  • Replaces the exportarr configuration with a new, more generic metrics configuration in values.yaml, values.schema.json, and related templates, allowing for greater flexibility in how metrics exporters are defined and deployed. [1] [2] [3] [4]
  • Removes the old arr-common.exportarr.container and port templates, and introduces new arr-common.metrics.container and port templates to support the new configuration. [1] [2]

Template and Service Updates

  • Updates deployment and service templates to use the new metrics configuration and container, ensuring the metrics exporter is deployed and exposed according to the new settings. [1] [2]
  • Updates the ServiceMonitor template to reference the new metrics port and path, and to conditionally include the metrics endpoint based on the new configuration.

Documentation and Metadata

  • Updates the chart version to 0.2.0 and adds relevant keywords for discoverability, such as exporter and metrics. [1] [2]
  • Updates the README to document the new metrics configuration options and removes references to the old exportarr configuration. [1] [2] [3]

Schema and Defaults

  • Removes the exportarr schema and default values, and adds a comprehensive schema for the new metrics configuration, supporting additional customization (e.g., args, command, envFrom, securityContext, resources, volumeMounts). [1] [2] [3]
  • Updates default values to match the new metrics configuration structure.

These changes make the chart more flexible and maintainable for users who need to customize their metrics exporters.

@Matthew-Beckett Matthew-Beckett self-assigned this Mar 31, 2026
@Matthew-Beckett Matthew-Beckett requested a review from a team as a code owner March 31, 2026 21:35
@Matthew-Beckett Matthew-Beckett changed the title Convert arr-common chart exportarr property to more generic metricsExporter interface. Convert arr-common chart exportarr property to more generic metrics interface. Mar 31, 2026
@Matthew-Beckett Matthew-Beckett merged commit b25ebed into main Apr 1, 2026
13 checks passed
@Matthew-Beckett Matthew-Beckett deleted the feature/arr-common-metrics-exporter branch April 1, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants