Convert arr-common chart exportarr property to more generic metrics interface.#140
Merged
Merged
Conversation
…hich aren't supported by exportarr
arr-common chart exportarr property to more generic metricsExporter interface.arr-common chart exportarr property to more generic metrics interface.
This was referenced Mar 31, 2026
lareeth
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as the ground work for the rest of the missing arr-stack adjacent applications such as qBittorrent which are not supported by Exportarr to still use
arr-commonfor it's features, but have a more robust interface to push in custom configuration for their required exporter.Updates to the
arr-commonHelm library chart to replace the previousexportarrmetrics exporter configuration with a more flexible and extensiblemetricsconfiguration. The new approach allows for better customization of the metrics exporter container and its integration with the chart, including support for additional arguments, commands, environment variables, and resource settings.Key changes include:
Metrics Exporter Refactor
exportarrconfiguration with a new, more genericmetricsconfiguration invalues.yaml,values.schema.json, and related templates, allowing for greater flexibility in how metrics exporters are defined and deployed. [1] [2] [3] [4]arr-common.exportarr.containerand port templates, and introduces newarr-common.metrics.containerand port templates to support the new configuration. [1] [2]Template and Service Updates
metricsconfiguration and container, ensuring the metrics exporter is deployed and exposed according to the new settings. [1] [2]metricsport and path, and to conditionally include the metrics endpoint based on the new configuration.Documentation and Metadata
0.2.0and adds relevant keywords for discoverability, such asexporterandmetrics. [1] [2]metricsconfiguration options and removes references to the oldexportarrconfiguration. [1] [2] [3]Schema and Defaults
exportarrschema and default values, and adds a comprehensive schema for the newmetricsconfiguration, supporting additional customization (e.g.,args,command,envFrom,securityContext,resources,volumeMounts). [1] [2] [3]metricsconfiguration structure.These changes make the chart more flexible and maintainable for users who need to customize their metrics exporters.