Sync changes and fix hash usage to get BGLd build and sync

[van-orton]

Description

• synced code fixes;
• changes some hashing places to Keccak to remain compatible with current BGL chain;
• core binaries are now building and able to sync successfully;

[janus]

crypto_sha3_libBGL_crypto_sha3_a_CPPFLAGS = $(AM_CPPFLAGS)
crypto_sha3_libBGL_crypto_sha3_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)

crypto_libBGL_crypto_base_a_CPPFLAGS = $(AM_CPPFLAGS)
crypto_libBGL_crypto_base_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)

Shouldn't the second = be replaced by +=? And the above assignments are same, shouldn't one serve?

[van-orton]

AFAIK, in such statements in makefile as
crypto_sha3_libBGL_crypto_sha3_a_CPPFLAGS and
crypto_libBGL_crypto_base_a_CPPFLAGS
that prefixed path matters and serves for generation of makefiles, so there's some duplications occuring but the 'variable name' is important, below there is similar construct:
crypto_libBGL_crypto_sse41_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
crypto_libBGL_crypto_sse41_a_CPPFLAGS = $(AM_CPPFLAGS)
I am not super-experienced with autogen tooling, so may be some optimization could be done there. Looks in https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am similar approach is used.

[janus]

AFAIK, in such statements in makefile as
crypto_sha3_libBGL_crypto_sha3_a_CPPFLAGS and
crypto_libBGL_crypto_base_a_CPPFLAGS
that prefixed path matters and serves for generation of makefiles, so there's some duplications occuring but the 'variable name' is important, below there is similar construct:
crypto_libBGL_crypto_sse41_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
crypto_libBGL_crypto_sse41_a_CPPFLAGS = $(AM_CPPFLAGS)
I am not super-experienced with autogen tooling, so may be some optimization could be done there. Looks in https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am similar approach is used.

Okay....thanks