Fix genesis-merge: retry merge state check for API propagation#44
Fix genesis-merge: retry merge state check for API propagation#44github-actions[bot] merged 1 commit intomasterfrom
Conversation
gh pr merge returns before GitHub's API propagates the MERGED state. The immediate gh pr view reads stale state (OPEN), causing the workflow to report failure even though the merge succeeded. Add a retry loop (up to 10s) before declaring failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
|
/review [Auto-review] Adds a retry loop (5 attempts, 2s apart) to the merge state confirmation in genesis-merge.yml. Fixes a race condition where gh pr merge returns before the MERGED state propagates via the API, causing the workflow to falsely report failure and skip cache update. Ranked low on difficulty/novelty — straightforward infrastructure fix. Slightly higher on design for correctly diagnosing the root cause rather than working around it. |
|
JAR Bot: Review recorded from @sorpaas (1 reviews, 0 meta-reviews). |
|
JAR Bot: Merge failed unexpectedly (state: OPEN). |
Summary
gh pr mergereturns before GitHub's API propagates the MERGED state. The immediategh pr viewreads stale state (OPEN), causing the workflow to report failure and skip cache update — even though the merge succeeded.Adds a retry loop (5 attempts, 2s apart) before declaring failure. This fixes the race condition that caused PR #43's cache to need manual update.
Test plan
🤖 Generated with Claude Code