test(grey-types): proptest roundtrips for work types#662
Conversation
Genesis ReviewComparison targets:
How to reviewPost a comment with the following format (rank from best to worst): Use the short commit hashes above and To meta-review another reviewer's comment, react with 👍 or 👎. |
|
/review Mechanical proptest additions for WorkResult, WorkDigest, and AvailabilitySpec codec roundtrips — follows the same pattern established by e686a41 (crypto proptests). Ranked just below the crypto proptests on novelty since this is the second iteration of the same approach. Low difficulty as this is template-driven test generation. Clean and correct — all variants covered, good field randomization, no existing tests modified. |
|
JAR Bot: Quorum reached — triggering merge. |
|
/review Proptest codec roundtrips for WorkResult (all 6 variants), WorkDigest, and AvailabilitySpec. Extends existing proptest coverage to work types. Straightforward but useful — ranked lower on difficulty and design because these are mechanical roundtrip tests compared to the GRANDPA persistence table (04594f0) and harness perf timing (c781deb) which add new functionality. Pure test addition with no behavioral changes. |
|
JAR Bot: Quorum reached — triggering merge. |
|
/review Three codec roundtrip proptests for work types — covers all 6 WorkResult variants explicitly and exercises every field in WorkDigest (10 randomized fields). Methodical and complete. Ranked below e686a41 on difficulty because roundtrip tests require understanding the codec and type structure but not deep domain properties; the crypto proptests require reasoning about hash/Ed25519 invariants. Solid gap-filling coverage, safe to merge. |
|
JAR Bot: Quorum reached — triggering merge. |
73108a8 to
3ef8481
Compare
Add proptest codec roundtrip tests for WorkResult (all 6 variants), WorkDigest, and AvailabilitySpec. These types were previously only tested as nested components of WorkReport but lacked standalone coverage, especially for non-Ok WorkResult variants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3ef8481 to
b0ac1bb
Compare
|
/review Re-reviewing after rebase. New tests integrated cleanly alongside the disputes/stats proptests added to master while this PR was open. All 103 grey-types tests pass. All CI green. |
|
JAR Bot: Quorum reached — triggering merge. |
|
JAR Bot: Merged (quorum reached). |
Summary
WorkResult(all 6 variants),WorkDigest, andAvailabilitySpecWorkResultwas previously only tested with theOkvariant; this adds coverage forOutOfGas,Panic,BadExports,BadCode, andCodeOversizeWorkDigestandAvailabilitySpecwere only tested as nested components ofWorkReport; now have standalone proptest coverageAddresses #229.
Scope
This PR addresses: proptest codec roundtrip for work types (WorkResult, WorkDigest, AvailabilitySpec)
Remaining sub-tasks in #229:
Test plan
cargo test -p grey-types proptests— all 26 proptest roundtrips pass (23 existing + 3 new)cargo clippy -p grey-types --all-targets -- -D warnings— clean