Fix RailsAdapter::LoadedTooLateError with Zeitwerk#76
Merged
jaredonline merged 2 commits intoFeb 18, 2023
Merged
Conversation
Zeitwerk uses Ruby's built-in `autoload`, and `defined?` for an autoload constant always returns `"constant"`. So `defined?(::ApplicationController)` always returns `"constant"` in some situations. After this commit, check if `ApplicationController` is loaded or not by Active Support's `descendants` instead of `defined?`. This new way doesn't depend on Ruby's `autoload`.
Contributor
Author
|
@jaredonline |
Owner
|
Hey @kg8m and folks, sorry it's taken me 2 months to take a look at this. I will merge and roll this out today, thank you for the patch. |
jaredonline
approved these changes
Feb 18, 2023
Contributor
Author
|
Thanks a lot for your review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
Zeitwerk uses Ruby's built-in
autoload, anddefined?for an autoload constant always returns"constant". Sodefined?(::ApplicationController)always returns"constant"in some situations.After this pull request, GoogleAuthenticatorRails gem will check if
ApplicationControlleris loaded or not by Active Support'sdescendantsinstead ofdefined?. This new way doesn't depend on Ruby'sautoload.