Merged
Conversation
Can build and run in both VS2015 and VS2017
jaredpar
reviewed
Mar 30, 2017
| @@ -1,7 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="12.0"> | |||
| <Import Project="..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.12-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="'$(VisualStudioVersion)' == '14.0' And Exists('..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.12-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" /> | |||
Owner
There was a problem hiding this comment.
I think we can just delete VS 14.0 support altogether at build time. I've been settling on the idea of limting activey F5 development to VS 2017.
Collaborator
Author
There was a problem hiding this comment.
We could. But we don't need to. I very carefully implemented full VS2015/VS2017 round-tripping. This is the way we are encouraging all extension developers to build their VSIXes.
Collaborator
Author
|
Can we bring back VS2012/VS2013 run-time support? |
Owner
Sure. Should be as simple as:
I'm not sure why I ever changed 1 above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can build and run in both VS2015 and VS2017