Remove maxKeys limit feature from NodeCacheStore

[jaredwray]

Please check if the PR fulfills these requirements

• Followed the Contributing guidelines and Code of Conduct
• Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce?

Breaking Change - Feature Removal

Description

This PR removes the maxKeys limit feature from the NodeCacheStore class. The feature allowed users to set a maximum number of keys that could be stored in the cache, returning false when attempting to exceed this limit.

Changes Made

• Removed maxKeys option from NodeCacheStoreOptions type
• Removed _maxKeys private field from NodeCacheStore class
• Removed maxKeys getter and setter methods
• Removed maxKeys validation logic from the set() method
• Removed related tests for maxKeys functionality
• Updated README documentation to reflect the removal
• Bumped version to 3.0.0 to reflect breaking change

Rationale

The maxKeys feature added unnecessary complexity to the caching logic and is not commonly used. Removing it simplifies the codebase and reduces maintenance burden. Users requiring key limits can implement this logic at the application level if needed.

Test Plan

Existing unit tests have been updated to remove maxKeys-specific test cases. All remaining tests pass and cover the core caching functionality (set, get, ttl, clear, etc.).

https://claude.ai/code/session_01SY98RRSBdLQBanZEsGmqv4

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the NodeCacheStore by completely removing the maxKeys limit feature. This change aims to reduce codebase complexity and maintenance overhead, as the feature was deemed largely unused and could be implemented at the application level if required. The removal constitutes a breaking change, reflected in the package's version increment to 3.0.0.

Highlights

• Feature Removal: The maxKeys limit feature has been entirely removed from the NodeCacheStore class.
• Code Simplification: Eliminated maxKeys option from NodeCacheStoreOptions, removed the _maxKeys private field, and deprecated its getter/setter methods.
• Logic Streamlining: Removed the maxKeys validation logic from the set() method, simplifying cache entry.
• Documentation & Tests: Updated README documentation and removed corresponding unit tests to reflect the feature's removal.
• Breaking Change: The package version has been bumped to 3.0.0 to signify this breaking change.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the maxKeys functionality from the NodeCacheStore and updates the package version to 3.0.0. While the removal of maxKeys is aligned with the PR's goal, the internal statistics tracking (_stats object) remains, but without a public API to access the collected data. It is suggested to add a getStats() method to expose this information and make the stats feature fully functional.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (effcbe3) to head (b65f6dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2473      2438   -35     
  Branches       558       547   -11     
=========================================
- Hits          2473      2438   -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.