Skip to content

cacheable - fix: upgrade qified pair to 0.10.1#1631

Merged
jaredwray merged 2 commits intomainfrom
dep-upgrade/cacheable-qified
May 7, 2026
Merged

cacheable - fix: upgrade qified pair to 0.10.1#1631
jaredwray merged 2 commits intomainfrom
dep-upgrade/cacheable-qified

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

Summary

  • Upgrade qified (dep) and @qified/redis (devDep) from 0.9.0 to 0.10.1 in the cacheable package.
  • qified 0.10 renamed Qified.unsubscribe(topic) to Qified.unsubscribeMessage(topic). Updated sync.ts accordingly. The cacheable public API is unchanged.

Test plan

  • pnpm --filter cacheable build succeeds
  • pnpm --filter cacheable test passes (8 test files, 206 tests)

🤖 Generated with Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f93f91c) to head (c5437d7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1631   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2496      2496           
  Branches       555       556    +1     
=========================================
  Hits          2496      2496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependencies 'qified' and '@qified/redis' to version 0.10.1, along with related Redis packages, and updates the usage of the 'qified' API in 'packages/cacheable/src/sync.ts' by replacing 'unsubscribe' with 'unsubscribeMessage'. The reviewer identified a critical issue: while the unsubscribe method was updated, the corresponding 'subscribe' calls in the same file were not updated to 'subscribeMessage', which will likely break cache synchronization.

Comment thread packages/cacheable/src/sync.ts
Upgrade qified and @qified/redis from 0.9.0 to 0.10.1.

The qified 0.10 release renamed the Qified class's unsubscribe method to
unsubscribeMessage (the topic/queue-level unsubscribe is now scoped). Update
sync.ts to call unsubscribeMessage on namespace changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jaredwray jaredwray force-pushed the dep-upgrade/cacheable-qified branch from 638d500 to 85efe0b Compare May 7, 2026 01:35
@jaredwray
Copy link
Copy Markdown
Owner Author

Re: gemini-code-assist's review — the subscribe calls don't need to change. In qified 0.10 the Qified class still exposes subscribe(topic, handler); only unsubscribe was renamed to unsubscribeMessage (with a parallel unsubscribeTask for queues). The existing { handler: ... } shape we pass already matches the new TopicHandler type. Verified by inspecting qified@0.10.1/dist/index.d.mts and by running the cacheable test suite (8 files, 206 tests, all passing).

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Thank you for the clarification, @jaredwray. That makes sense. Since you have verified the subscribe behavior against the qified@0.10.1 definitions and confirmed that the existing handler shape remains compatible, the current implementation is correct. I appreciate you taking the time to verify this with the test suite.

@jaredwray jaredwray merged commit c53ebbd into main May 7, 2026
10 checks passed
@jaredwray jaredwray deleted the dep-upgrade/cacheable-qified branch May 7, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant