cacheable - fix: upgrade qified pair to 0.10.1#1631
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2496 2496
Branches 555 556 +1
=========================================
Hits 2496 2496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies 'qified' and '@qified/redis' to version 0.10.1, along with related Redis packages, and updates the usage of the 'qified' API in 'packages/cacheable/src/sync.ts' by replacing 'unsubscribe' with 'unsubscribeMessage'. The reviewer identified a critical issue: while the unsubscribe method was updated, the corresponding 'subscribe' calls in the same file were not updated to 'subscribeMessage', which will likely break cache synchronization.
Upgrade qified and @qified/redis from 0.9.0 to 0.10.1. The qified 0.10 release renamed the Qified class's unsubscribe method to unsubscribeMessage (the topic/queue-level unsubscribe is now scoped). Update sync.ts to call unsubscribeMessage on namespace changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
638d500 to
85efe0b
Compare
|
Re: gemini-code-assist's review — the |
|
Thank you for the clarification, @jaredwray. That makes sense. Since you have verified the |
Summary
qified(dep) and@qified/redis(devDep) from 0.9.0 to 0.10.1 in thecacheablepackage.Qified.unsubscribe(topic)toQified.unsubscribeMessage(topic). Updatedsync.tsaccordingly. The cacheable public API is unchanged.Test plan
pnpm --filter cacheable buildsucceedspnpm --filter cacheable testpasses (8 test files, 206 tests)🤖 Generated with Claude Code