Add 'start' command that builds, watches, and serves the site#360
Add 'start' command that builds, watches, and serves the site#360
Conversation
The start command combines build + watch + serve into a single command, making it easy to start a development session with `docula start`. https://claude.ai/code/session_01KawTM1nkP1JXqFzUo1Qt4f
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the developer experience by introducing a new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a convenient start command that combines building, watching, and serving the site, which simplifies the development workflow. The implementation is correct and well-tested. My review focuses on improving maintainability by addressing code duplication that was introduced. Specifically, I've suggested refactoring the command execution logic in docula.ts and the help message generation in console.ts to reduce repetition and make the code easier to manage in the future.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77f9b0f6f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "start": { | ||
| return "start"; |
There was a problem hiding this comment.
Parse command only from positional CLI argument
getCommand iterates across every argv token, so adding the new "start" branch makes option values accidentally select the command; for example, docula --site start now resolves to the start workflow (build+watch+serve) instead of the default build path. This is a regression introduced by this change and affects any invocation where a flag value is literally start, so command detection should be limited to the positional command token rather than all arguments.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 7 7
Lines 1796 1805 +9
Branches 524 527 +3
=======================================
+ Hits 1795 1804 +9
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The start command combines build + watch + serve into a single command,
making it easy to start a development session with
docula start.https://claude.ai/code/session_01KawTM1nkP1JXqFzUo1Qt4f