Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 413 413
Branches 96 96
=========================================
Hits 413 413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript version to 6.0.2 and enhances the compiler configuration in tsconfig.json with several new strictness flags, including noUncheckedIndexedAccess, noImplicitOverride, and verbatimModuleSyntax. However, the specified TypeScript version appears to be invalid as the current major version is 5. Furthermore, enabling noUncheckedIndexedAccess is expected to break the build due to existing unsafe array indexing in the codebase. It is also recommended to restore the descriptive comments removed from the configuration file to maintain readability.
| "module": "nodenext", | ||
| "moduleResolution": "nodenext", | ||
| "strict": true, | ||
| "noUncheckedIndexedAccess": true, |
There was a problem hiding this comment.
Enabling noUncheckedIndexedAccess is a good practice for type safety, but it will break the current build. The codebase contains several instances of array indexing without safety checks. For example, in src/engines/handlebars.ts at lines 78 and 83, dp.split(".")[0] and p.split(".")[0] are used in contexts that require a string, but they will now be typed as string | undefined. Please update the source code to handle these cases before enabling this flag.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading to typescript