Skip to content

chore: upgrading to typescript#347

Merged
jaredwray merged 1 commit intomainfrom
chore-upgrading-to-typescript
Apr 9, 2026
Merged

chore: upgrading to typescript#347
jaredwray merged 1 commit intomainfrom
chore-upgrading-to-typescript

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 9, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading to typescript

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (16895b7) to head (663268e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          413       413           
  Branches        96        96           
=========================================
  Hits           413       413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit e105b48 into main Apr 9, 2026
9 checks passed
@jaredwray jaredwray deleted the chore-upgrading-to-typescript branch April 9, 2026 00:49
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TypeScript version to 6.0.2 and enhances the compiler configuration in tsconfig.json with several new strictness flags, including noUncheckedIndexedAccess, noImplicitOverride, and verbatimModuleSyntax. However, the specified TypeScript version appears to be invalid as the current major version is 5. Furthermore, enabling noUncheckedIndexedAccess is expected to break the build due to existing unsafe array indexing in the codebase. It is also recommended to restore the descriptive comments removed from the configuration file to maintain readability.

"module": "nodenext",
"moduleResolution": "nodenext",
"strict": true,
"noUncheckedIndexedAccess": true,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Enabling noUncheckedIndexedAccess is a good practice for type safety, but it will break the current build. The codebase contains several instances of array indexing without safety checks. For example, in src/engines/handlebars.ts at lines 78 and 83, dp.split(".")[0] and p.split(".")[0] are used in contexts that require a string, but they will now be typed as string | undefined. Please update the source code to handle these cases before enabling this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant