Migrate release workflow to OIDC with provenance#370
Merged
Conversation
Remove NPM_TOKEN secret usage and configure setup-node with registry-url for OIDC-based npm publishing. The id-token: write permission enables provenance attestation and trusted publishing without stored credentials. https://claude.ai/code/session_01SY3mQSBYHYHEELdGjdBUPx
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 413 413
Branches 96 96
=========================================
Hits 413 413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62e5a742f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
setup-node with registry-url writes _authToken=${NODE_AUTH_TOKEN} to
.npmrc, which causes pnpm <11.2.0 to fail with 404 when the env var
is unset. Since OIDC auth is handled by --provenance + id-token:write,
registry-url is not needed — the default registry is already npmjs.org.
https://claude.ai/code/session_01SY3mQSBYHYHEELdGjdBUPx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM_TOKENsecret usage (pnpm config setandNODE_AUTH_TOKENenv var)registry-urltosetup-nodefor proper OIDC-based npm publishing--access publicand--no-git-checksflags to publish stepThe
id-token: writepermission combined with--provenanceenables trusted publishing via OIDC without stored npm credentials.Note: The
ectopackage must be configured for trusted publishing on npmjs.com to allow OIDC-based authentication from this repository.Test plan
ectopackage on npmjs.comhttps://claude.ai/code/session_01SY3mQSBYHYHEELdGjdBUPx
Generated by Claude Code