ecto - chore: harden pnpm-workspace.yaml with supply chain controls#375
Merged
Conversation
Apply agentic defense-in-depth Section 4 recommended baseline: - minimumReleaseAge 2880 → 10080 (7 days) - minimumReleaseAgeStrict: true - minimumReleaseAgeIgnoreMissingTime: false - blockExoticSubdeps: true - strictDepBuilds: true - dangerouslyAllowAllBuilds: false - trustPolicy: no-downgrade
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to add several supply chain security configuration options to pnpm-workspace.yaml. However, these fields are not supported or recognized by pnpm in this file, which could lead to parsing errors. It is recommended to use standard pnpm configuration fields in package.json instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 413 413
Branches 96 96
=========================================
Hits 413 413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply agentic defense-in-depth Section 4 recommended baseline to
pnpm-workspace.yaml.Changes
minimumReleaseAge2880→10080(7 days, up from 2 days)minimumReleaseAgeStrict: true— resolution fails instead of falling back to too-new versionsminimumReleaseAgeIgnoreMissingTime: false— missing publish-time metadata fails closedblockExoticSubdeps: true— blocks exotic subdependency sourcesstrictDepBuilds: true— strict lifecycle script controldangerouslyAllowAllBuilds: false— explicit denial of unchecked build scriptstrustPolicy: no-downgradeallowBuildsentries (esbuild, unrs-resolver, @biomejs/biome, workerd)Verification
pnpm install --frozen-lockfilepassespnpm buildpassespnpm testpasses (237 tests, 100% coverage)Reference
defense-in-depth-nodejs.md § 4
Generated by Claude Code