chore: upgrading biome, vitest, swc to latest#130
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 1063 1063
Branches 211 211
=========================================
Hits 1063 1063 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates several development dependencies, including @biomejs/biome, @swc/core, and vitest, to newer versions and synchronizes the pnpm-lock.yaml file. It also modifies the package.json scripts by replacing the prepare hook with prepublishOnly. Feedback suggests that changing the prepare script is a regression in the build workflow because it prevents the project from building automatically after a local installation, which is necessary for the start script to function correctly on fresh clones.
| "docker:compose:up": "docker-compose up -d", | ||
| "docker:compose:down": "docker-compose down", | ||
| "prepare": "pnpm run build", | ||
| "prepublishOnly": "pnpm run build", |
There was a problem hiding this comment.
Changing the prepare script to prepublishOnly is a regression in the build workflow. The prepare script ensures that the project is built automatically after a local pnpm install, which is necessary for the start script (node dist/index.js) to work correctly on a fresh clone. With prepublishOnly, developers will have to manually run pnpm build after installation. It is recommended to keep this as prepare to maintain a smooth developer experience.
| "prepublishOnly": "pnpm run build", | |
| "prepare": "pnpm run build", |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading biome, vitest, swc to latest