Skip to content

chore: upgrading biome, vitest, swc to latest#130

Merged
jaredwray merged 1 commit intomainfrom
chore-upgrading-biome,-vitest,-swc-to-latest
Apr 14, 2026
Merged

chore: upgrading biome, vitest, swc to latest#130
jaredwray merged 1 commit intomainfrom
chore-upgrading-biome,-vitest,-swc-to-latest

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 14, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading biome, vitest, swc to latest

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3a376f3) to head (ee213a2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1063      1063           
  Branches       211       211           
=========================================
  Hits          1063      1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 564d838 into main Apr 14, 2026
9 checks passed
@jaredwray jaredwray deleted the chore-upgrading-biome,-vitest,-swc-to-latest branch April 14, 2026 11:29
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several development dependencies, including @biomejs/biome, @swc/core, and vitest, to newer versions and synchronizes the pnpm-lock.yaml file. It also modifies the package.json scripts by replacing the prepare hook with prepublishOnly. Feedback suggests that changing the prepare script is a regression in the build workflow because it prevents the project from building automatically after a local installation, which is necessary for the start script to function correctly on fresh clones.

Comment thread package.json
"docker:compose:up": "docker-compose up -d",
"docker:compose:down": "docker-compose down",
"prepare": "pnpm run build",
"prepublishOnly": "pnpm run build",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing the prepare script to prepublishOnly is a regression in the build workflow. The prepare script ensures that the project is built automatically after a local pnpm install, which is necessary for the start script (node dist/index.js) to work correctly on a fresh clone. With prepublishOnly, developers will have to manually run pnpm build after installation. It is recommended to keep this as prepare to maintain a smooth developer experience.

Suggested change
"prepublishOnly": "pnpm run build",
"prepare": "pnpm run build",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant