Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 1063 1063
Branches 211 211
=========================================
Hits 1063 1063 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the build system from tsup to tsdown, upgrades TypeScript to version 6.0.2, and transitions the project to ESM by using .mjs and .d.mts extensions. It also introduces a clean script and removes decorator-related configurations from tsconfig.json. Feedback was provided to include the removal of the dist directory in the build script to prevent stale artifacts and to refine the clean script to avoid the aggressive removal of node_modules during standard cleanup tasks.
| "test:ci": "biome check --error-on-warnings && vitest run --coverage", | ||
| "dev": "pnpm lint && tsx src/index.ts --watch", | ||
| "build": "rimraf ./dist && tsup src/index.ts --format esm --dts --clean", | ||
| "build": "tsdown src/index.ts --format esm --dts", |
There was a problem hiding this comment.
The build script no longer cleans the dist directory before building. This can lead to stale build artifacts being present in the output, which might cause unexpected behavior. It's a good practice to ensure a clean build environment by removing the output directory before each build.
| "build": "tsdown src/index.ts --format esm --dts", | |
| "build": "rimraf ./dist && tsdown src/index.ts --format esm --dts", |
| "dev": "pnpm lint && tsx src/index.ts --watch", | ||
| "build": "rimraf ./dist && tsup src/index.ts --format esm --dts --clean", | ||
| "build": "tsdown src/index.ts --format esm --dts", | ||
| "clean": "rimraf ./node_modules ./dist ./coverage DOCKER.md", |
There was a problem hiding this comment.
The clean script removes node_modules, which is quite aggressive for a standard clean task and forces a full dependency re-installation. This can slow down the development workflow. Typically, a clean script is for removing build artifacts and temporary files.
Consider renaming this to clean:all or deep-clean and having a more standard clean script that only removes build artifacts like dist, coverage, and generated files.
1 participant
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat: migrating from tsup to tsdown