Skip to content

mono - chore: upgrading typescript, tsdown, and docula#183

Merged
jaredwray merged 1 commit intomainfrom
mono---chore-upgrading-typescript,-tsdown,-and-docula
Apr 23, 2026
Merged

mono - chore: upgrading typescript, tsdown, and docula#183
jaredwray merged 1 commit intomainfrom
mono---chore-upgrading-typescript,-tsdown,-and-docula

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 23, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - chore: upgrading typescript, tsdown, and docula

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ca68012) to head (902cd46).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1266      1266           
  Branches       232       231    -1     
=========================================
  Hits          1266      1266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit ff48951 into main Apr 23, 2026
8 checks passed
@jaredwray jaredwray deleted the mono---chore-upgrading-typescript,-tsdown,-and-docula branch April 23, 2026 16:21
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in package.json and pnpm-lock.yaml, including upgrades to docula, tsdown, typescript, and various @ai-sdk packages. Additionally, the website:serve script in package.json was renamed to website:dev. I have provided a suggestion to include a website:serve script that runs docula serve to facilitate production previewing, which complements the existing development workflow.

Comment thread package.json
"test:services:stop": "docker compose down",
"website:build": "docula build",
"website:serve": "docula dev",
"website:dev": "docula dev",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming website:serve to website:dev correctly aligns the script name with the docula dev command. However, it is common practice to also have a serve script for previewing the production build (usually after running website:build). Consider adding a website:serve script that executes docula serve to provide a complete development and preview workflow.

Suggested change
"website:dev": "docula dev",
"website:dev": "docula dev",
"website:serve": "docula serve",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant