Skip to content

rabbitmq - chore: adding in test coverage#185

Merged
jaredwray merged 1 commit intomainfrom
rabbitmq---chore-adding-in-test-coverage
Apr 23, 2026
Merged

rabbitmq - chore: adding in test coverage#185
jaredwray merged 1 commit intomainfrom
rabbitmq---chore-adding-in-test-coverage

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 23, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
rabbitmq - chore: adding in test coverage

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (70115d3) to head (328b962).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1266      1264    -2     
  Branches       231       231           
=========================================
- Hits          1266      1264    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit ccf9629 into main Apr 23, 2026
9 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces v8 ignore markers to an auto-reject block in the RabbitMQ task provider and adds several edge-case tests covering connection idempotency, timeout behaviors, and multiple handler rejections. Feedback suggests removing the coverage ignore markers in favor of explicit error-path testing, refactoring tests to use the public dequeue API instead of accessing private members, and adding assertions to ensure that side effects like dead-lettering occur only once.

Comment thread packages/rabbitmq/test/task-edge.test.ts
Comment thread packages/rabbitmq/src/task.ts
Comment thread packages/rabbitmq/test/task-edge.test.ts
Comment thread packages/rabbitmq/test/task-edge.test.ts
Comment thread packages/rabbitmq/test/task-edge.test.ts
@jaredwray jaredwray deleted the rabbitmq---chore-adding-in-test-coverage branch April 23, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant