Skip to content

mono - fix: rabbit and nats with better connection handling#189

Merged
jaredwray merged 3 commits intomainfrom
mono---fix-rabbit-and-nats-with-better-connection-handling
Apr 23, 2026
Merged

mono - fix: rabbit and nats with better connection handling#189
jaredwray merged 3 commits intomainfrom
mono---fix-rabbit-and-nats-with-better-connection-handling

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 23, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - fix: rabbit and nats with better connection handling

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3f72aab) to head (a61643d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1304      1323   +19     
  Branches       230       237    +7     
=========================================
+ Hits          1304      1323   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements publisher confirms for RabbitMQ and NATS to ensure message delivery is acknowledged by the broker. It transitions RabbitMQ to use ConfirmChannel and updates the publish, enqueue, and moveToDeadLetter methods to await acknowledgments via promises. Typographical errors in the Redis provider are also corrected. Review feedback identifies concurrency vulnerabilities in the RabbitMQ connection logic, specifically recommending a connection promise to prevent redundant connection attempts and emphasizing the need to reset this promise upon connection closure to allow for proper recovery.

Comment thread packages/rabbitmq/src/index.ts
Comment thread packages/rabbitmq/src/index.ts
Comment thread packages/rabbitmq/src/task.ts
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 846313d027

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rabbitmq/src/task.ts
@jaredwray jaredwray merged commit 5e6e735 into main Apr 23, 2026
9 checks passed
@jaredwray jaredwray deleted the mono---fix-rabbit-and-nats-with-better-connection-handling branch April 23, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant