mono - fix: providerId and reconnect / connection fixes#190
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c46c58d009
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Code Review
This pull request introduces reconnection logic and configurable wait times for NATS providers, removes the priority field from tasks across all providers, and makes providerId a mandatory field in messages. It also improves connection management in the RabbitMQ provider by gating concurrent connection attempts with a promise. Feedback focuses on addressing a potential race condition in NATS connection creation and refining the RabbitMQ connection lifecycle to prevent connection leaks or unexpected behavior during shutdown.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1323 1365 +42
Branches 236 241 +5
=========================================
+ Hits 1323 1365 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - fix: providerId and reconnect / connection fixes