Skip to content

mono - fix: providerId and reconnect / connection fixes#190

Merged
jaredwray merged 2 commits intomainfrom
rabbitmq---concurrent-connect-gate-and-nack-fix
Apr 24, 2026
Merged

mono - fix: providerId and reconnect / connection fixes#190
jaredwray merged 2 commits intomainfrom
rabbitmq---concurrent-connect-gate-and-nack-fix

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 23, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - fix: providerId and reconnect / connection fixes

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c46c58d009

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rabbitmq/src/index.ts
Comment thread packages/rabbitmq/src/task.ts Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces reconnection logic and configurable wait times for NATS providers, removes the priority field from tasks across all providers, and makes providerId a mandatory field in messages. It also improves connection management in the RabbitMQ provider by gating concurrent connection attempts with a promise. Feedback focuses on addressing a potential race condition in NATS connection creation and refining the RabbitMQ connection lifecycle to prevent connection leaks or unexpected behavior during shutdown.

Comment thread packages/nats/src/index.ts
Comment thread packages/nats/src/index.ts
Comment thread packages/rabbitmq/src/index.ts
Comment thread packages/rabbitmq/src/index.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5e6e735) to head (0d434ff).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1323      1365   +42     
  Branches       236       241    +5     
=========================================
+ Hits          1323      1365   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 3772076 into main Apr 24, 2026
9 checks passed
@jaredwray jaredwray deleted the rabbitmq---concurrent-connect-gate-and-nack-fix branch April 24, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant