Skip to content

chore: upgrading cacheable and hashery#441

Merged
jaredwray merged 1 commit intomainfrom
chore-upgrading-cacheable-and-hashery
Mar 27, 2026
Merged

chore: upgrading cacheable and hashery#441
jaredwray merged 1 commit intomainfrom
chore-upgrading-cacheable-and-hashery

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Mar 27, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading cacheable and hashery

@codecov
Copy link

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0080e9b) to head (eee49a3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          470       470           
  Branches       107       105    -2     
=========================================
  Hits           470       470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of cacheable and hashery in package.json and the lockfile. A review comment points out that these updates result in multiple versions of the hookified dependency being included in the project, as cacheable and hashery still rely on version 1.15.1 while the root project and the transitive dependency qified have moved to version 2.1.0. It is recommended to update to versions of cacheable and hashery that support the newer hookified version to reduce bundle size and avoid potential conflicts.

@jaredwray jaredwray merged commit 62b98b2 into main Mar 27, 2026
11 checks passed
@jaredwray jaredwray deleted the chore-upgrading-cacheable-and-hashery branch March 27, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant