Skip to content

chore: upgrading marked to 18.0.2#447

Merged
jaredwray merged 1 commit intomainfrom
chore-upgrading-marked-to-18.0.2
Apr 26, 2026
Merged

chore: upgrading marked to 18.0.2#447
jaredwray merged 1 commit intomainfrom
chore-upgrading-marked-to-18.0.2

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 26, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading marked to 18.0.2

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (683a902) to head (e0653bd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #447   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          518       518           
  Branches       145       144    -1     
=========================================
  Hits           518       518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the marked dependency to version 18 and removes the baseUrl configuration from tsconfig.json. The reviewer noted that the marked upgrade introduces breaking changes, including a higher Node.js requirement and deprecated methods that need updating in the benchmark files. Additionally, the removal of baseUrl may disrupt module resolution for non-relative imports across the project.

Comment thread package.json
Comment thread tsconfig.json
@jaredwray jaredwray merged commit c172f93 into main Apr 26, 2026
11 checks passed
@jaredwray jaredwray deleted the chore-upgrading-marked-to-18.0.2 branch April 26, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant