Skip to content

Move require call to own method#18

Merged
jarmo merged 1 commit intojarmo:masterfrom
adam12:require-separate-method
Dec 29, 2017
Merged

Move require call to own method#18
jarmo merged 1 commit intojarmo:masterfrom
adam12:require-separate-method

Conversation

@adam12
Copy link
Copy Markdown
Contributor

@adam12 adam12 commented Oct 30, 2017

I normalized both calls to Kernel.send(options[:method], file) into their own method.

Right or wrong, I need to monkeypatch this method to support the auto_reloader gem, which uses Object.require and not Kernel.require.

It would be great to push this further, where a callable object with filename could be provided, instead of presuming a method on Kernel would be called. I might submit a PR for this if there is interest.

Much thanks.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 30, 2017

Coverage Status

Coverage decreased (-1.5%) to 96.436% when pulling 44aa0b0 on adam12:require-separate-method into 85f7d85 on jarmo:master.

@jarmo jarmo merged commit 44aa0b0 into jarmo:master Dec 29, 2017
@jarmo
Copy link
Copy Markdown
Owner

jarmo commented Dec 29, 2017

Merged and released version 1.5.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants