Disable warnings #452
Merged
Disable warnings #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `gcc` to elide the copy in the return and keeps it from warning with `-Wnvro` enabled.
The definition of the dtor is not necessary and actually harmful since the definition of a class's implicit copy constructor is deprecated if that class has a user-declared constructor as of C++11. Compilers can warn about this with `-Wdeprecated`.
|
I'd like to see e96358d being taken over into master if nothing speaks against it. Reason: Apple clang 17 running with Taking only the destructor out while a constructor is still present is a warning sign regarding the rule of three, but looking at the constructor I think this is safe. See also discussion regarding this in context of rule of three on https://stackoverflow.com/questions/51863588/warning-definition-of-implicit-copy-constructor-is-deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is