Update tests #9
Merged
Update tests #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updown.io no longer is returning a certificate with an authorityInfoAccess extension so it's falling back to CLR checks, so we need to update our tests to use another domain: google.com is fine!
Owner
|
Great thanks for these updates ! |
Owner
|
For the record, I just fixed/improved/removed a few extra tests in 37e4a31, the suite is now green: https://github.com/jarthod/ssl-test/actions/runs/19194180382/job/54872742350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the tests were failing due to domains and certificates changing. They now all pass except for one as I can't actually find an online example of a revoked certificate that uses ocsp. So there is still one test failing, as https://revoked.badssl.com/ no longer uses OCSP, it uses CRL.