Skip to content

BREAKING: change defineAccessor's generic order#181

Merged
jason89521 merged 1 commit intomainfrom
BREAKING/change-generic-order
Jul 21, 2023
Merged

BREAKING: change defineAccessor's generic order#181
jason89521 merged 1 commit intomainfrom
BREAKING/change-generic-order

Conversation

@jason89521
Copy link
Copy Markdown
Owner

Proposed change

close #179

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Testing
  • Refactor
  • Chore (tool changes, configuration changes, and changes to things that do not actually go into production at all)

Implementation

Related Issue

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2023

Codecov Report

Merging #181 (911e922) into main (be9edcd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          30       30           
  Lines        1997     1997           
  Branches      306      306           
=======================================
  Hits         1951     1951           
  Misses         46       46           
Impacted Files Coverage Δ
src/lib/model/Model.ts 98.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jason89521 jason89521 merged commit 24d56fc into main Jul 21, 2023
@jason89521 jason89521 deleted the BREAKING/change-generic-order branch July 21, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move Data to the first generic for defineAccessor method

1 participant