Skip to content

fix(gps): warn in dev when polling refcount goes out of bounds #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasoneplumb merged 2 commits into from
Apr 19, 2026
Merged

fix(gps): warn in dev when polling refcount goes out of bounds #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e204ab
fix(gps): warn in dev when activatePolling() refcount exceeds 2
Apr 19, 2026
553c8de
fix(gps): add symmetric underflow guard in deactivatePolling()
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,18 @@ map.on('locationerror', (e: L.ErrorEvent) => {
// Polling refcount helpers — shared by locate and recording
function activatePolling(): void {
state.updateCallback += 1;
if (import.meta.env.DEV && state.updateCallback > 2) {
console.warn('[webmap] updateCallback > 2 — possible activatePolling() leak', state.updateCallback);
}
if (state.updateCallback === 1) startWatching(map);
}

function deactivatePolling(): void {
state.prior = 1000;
state.updateCallback -= 1;
if (import.meta.env.DEV && state.updateCallback < 0) {
console.warn('[webmap] updateCallback < 0 — possible deactivatePolling() leak', state.updateCallback);
}
if (state.updateCallback === 0) stopWatching(map);
}

Expand Down
Loading