Decode embedded column names in analysis results#8
Open
FBartos wants to merge 6 commits into
Open
Conversation
loadQmlAndParseOptions now calls syntaxBridgeLoadQmlAndParseOptionsStatus, which returns a JSON status object following the same pattern as other bridge functions. Errors from the QML form (e.g. unresolved formula terms) are surfaced via Rcpp::stop instead of being silently swallowed as an empty return value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
decodeAnalysisResults()already decoded result strings when the full string was exactly an encoded JASP column name, such asjaspColumn2orJaspColumn_1_Encoded.However, some result payload fields contain encoded column names embedded inside larger strings. In the MixedModels replay path this showed up in the ANOVA summary:
jaspColumn2 ? jaspColumn3This made the native replay look mostly correct while still leaking bridge/internal column tokens in user-facing result text.
Change
This updates the generic result decoder in
jaspSyntaxso it also detects encoded column-name tokens inside character strings and replaces only those tokens via the available column mapping/native decoder.The fix stays at the
jaspSyntax::decodeAnalysisResults()boundary instead of adding module-specific decoding logic in jaspTools or jaspMixedModels.Validation
jaspColumn10is not accidentally rewritten from a shorter mapping.testthat::test_file("tests/testthat/test-dataset-helpers.R")successfully on Windows/R 4.6 with local bridge runtime DLL paths onPATH.Chronotype ? TimeOfDay, the random-effects footnote decoded toSubject, and the ANOVA summary had zero remainingjaspColumn/JaspColumn_hits.