Fix plot fallback snapshots#82
Open
FBartos wants to merge 2 commits into
Open
Conversation
4cc1e3a to
0e95e0b
Compare
Contributor
Author
|
Added the companion fix for the eager-decoded result-state contract in jaspBase. Changes here:
Verified with:
Related jaspBase work: jasp-stats/jaspBase#204. |
Contributor
Author
|
@vandenman this is ready for your review. The jaspTools side remains orchestration-only; the paired jaspBase provenance fix has been pushed and the focused bridge/replay checks pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ggplot visual snapshot fallback lifecycle and the slowdown caused by repeatedly falling back through structural snapshots.
New behavior
.rdssnapshots are maintained as fallback fixtures..new.svgreview path and asks the user to accept the visual fixture so future runs do not keep using the slower fallback..new.svgfiles are no longer treated as current mismatches.options(jaspTools.plotSnapshot.gc = FALSE)disables it.Validation
testthat::test_dir(tests/testthat, reporter = summary)passes.git diff --checkpasses, apart from existing CRLF warnings on Windows.rcmdcheck::rcmdcheck(args = c(--no-manual, --as-cran, --no-examples), error_on = never)has 0 errors and only the existing allowed warning/notes.@vandenman could you review this plot snapshot fallback behavior?