Not needed boxing method calls are emitted

[Marcono1234]

Version

1.1.3+, Commit 7f01508

Description

When decompiling a class which uses boxing (e.g. Integer <-> int), currently the boxing calls are always emitted.

However, in some cases these boxing calls are required (or the equivalent cast has to be emitted), e.g. when overloaded methods are called.

Source:

class Test {
    void test() {
        Integer intObj = 10;
        int i = intObj;
    }
}

Decompiled output:

class Test {
    void test() {
        Integer integer = Integer.valueOf(10);
        int i = integer.intValue();
    }
}

[Marcono1234]

@emmanue1, sorry for the trouble, but sadly you cannot always drop the boxing calls without introducing behavior changes.

Here are two examples (though there are likely more cases):

class BoxingCalls {
    void use(int i) { }
    void use(Integer i) { }
    
    Integer getInt() {
        return null;
    }
    
    void test() {
        // Needed to call correct overloaded method
        use((Integer) 1);
        // Needed for null check
        getInt().intValue();
    }
}