fix: preserve base env when optional override fails and reset init state on clean()#143
Merged
java-james merged 1 commit intomasterfrom Apr 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load(isOptional: true)no longer discards a successfully loaded base.envfile when an override file is missing or empty. The single try/catch` wrapping both loads has been replaced with independent error handling per source file.clean()now resetsisInitializedtofalse, so the instance no longer reports as initialized with an empty map after clearing._getLinesFromOverridehelper (logic inlined intoload()).Motivation
When using
load(isOptional: true)with override files, a missing or empty override would silently zero out the successfully loaded base file variables — a data-loss bug. Four separate issues reported this class of problem.Separately,
clean()only cleared the env map but leftisInitialized == true, creating a zombie state whereenvreturned an empty map instead of throwingNotInitializedError.Fixes #101, #125
Breaking change
clean()now resets initialization state. Code that callsclean()then accessesdotenv.envwithout reloading will now throwNotInitializedError. This corrects buggy behavior — the previous pattern was never intentional or documented.Test plan
clean()setsisInitializedto falseenvthrowsNotInitializedErrorafterclean()loadFromString()re-initializes correctly afterclean()isOptional: truepreserves base varsisOptional: truepreserves override varsisOptional: falsestill throws with empty base even if override is validflutter analyzeclean (no new warnings)