Fix switched serverName/domainName arguments in Netapi32Util#getDCName#1721
Merged
dbwiddis merged 1 commit intoMay 10, 2026
Merged
Conversation
Closes java-native-access#1650 The arguments to NetGetDCName were passed in the wrong order (domainName, serverName) instead of (serverName, domainName).
matthiasblaesing
approved these changes
May 10, 2026
Member
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Makes sense. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the argument order in
Netapi32Util#getDCNamewhich was passing(domainName, serverName, bufptr)toNetapi32#NetGetDCNameinstead of the correct(serverName, domainName, bufptr).The
NetGetDCNameWindows API expectsserverNamefirst anddomainNamesecond. The bug was unnoticed because all existing callers pass(null, null).Closes #1650