Replace inline JS with gh pr comment scripts#14
Merged
Conversation
Workflow cleanup: - Extract all inline bash/Python from workflows into scripts/ - Replace Python scripts (notify-slack, update-task-def, create-override-token) with shell equivalents using curl, jq, aws CLI - Scripts self-resolve SSM webhook URLs via SSM_WEBHOOK_PARAM env var - Only remaining Python is review-plan.py (Bedrock SDK) - plan-review only alerts Slack on HIGH risk with override link Registry provisioning: - Add javabin-ci-registry OIDC role scoped to lambda:InvokeFunction on team-provisioner (ARN constructed from naming convention) - Delete provision-app.yml (registry invokes Lambda directly now) - Add provision-teams.sh (yq + aws lambda invoke) Housekeeping: - Delete stale repos/ directory (old scaffolding copies) - Delete notify-block.py (replaced by notify-slack.sh) - Update CLAUDE.md
- Extract PR comment logic to post-plan-comment.sh and post-review-comment.sh - Use gh pr comment --body-file instead of inline JavaScript - Remove actions/github-script dependency from all workflows
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟡 MEDIUM Risk: 🟡 MEDIUM CloudTrail resource is being force-replaced due to tainting, with configuration warnings about S3 lifecycle rules that need attention.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - Replace all 4 `actions/github-script` blocks with `gh pr comment --body-file` - New scripts: `post-plan-comment.sh`, `post-review-comment.sh` - Zero inline JavaScript remaining in any workflow ## Test plan - [ ] Open a PR with TF changes — verify plan and review comments post correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/github-scriptblocks withgh pr comment --body-filepost-plan-comment.sh,post-review-comment.shTest plan