Slack alert improvements, dedup, and CI consolidation#45
Merged
Conversation
Slack alerts: - Fix hero provisioner formatting — always-table with Type/Email/Status - Add DynamoDB dedup for Security Hub + compliance alerts (30-day TTL) - Add "View & Suppress" link button on Security Hub alerts (console deep-link) - Add weekly Security Hub summary Lambda with table format (Monday 08:00 UTC) - Consolidate HIGH risk alert into single rich message with findings + override button - Remove duplicate alert from check-risk-block.sh CI consolidation: - Merge plan-review.yml into tf-plan.yml (saves job startup + S3 re-download) - Merge platform-ci review job inline into plan job (same pattern) - Delete unused commit-terraform.yml and plan-review.yml - Remove plan-review.yml from OIDC trust policy - Update ruleset required check (done via gh CLI separately)
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟢 LOW Routine infrastructure updates adding Security Hub summary automation and alert deduplication with Lambda code updates.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - Fix hero provisioner Slack formatting — always-table with emoji status cells - Add DynamoDB dedup for Security Hub + compliance alerts (prevents re-alerting same finding for 30 days) - Add "View & Suppress in Security Hub" link button on findings (opens console, user authenticates via Identity Center) - Add weekly Security Hub summary Lambda with Block Kit table (Severity/Type/Resource/Finding), scheduled Monday 08:00 UTC - Consolidate duplicate HIGH risk Slack alerts into single rich message with LLM findings and override button - Merge `plan-review.yml` into `tf-plan.yml` — review runs inline after plan in same job - Merge platform-ci review job inline into plan job (same pattern) - Delete unused `commit-terraform.yml` and `plan-review.yml` - Remove `plan-review.yml` from OIDC trust policy - Enable auto-merge on repo, update ruleset required status check (done via `gh` CLI) ## Test plan - [ ] Verify "Terraform Plan" CI job runs plan + LLM review in a single job - [ ] Trigger hero sync — confirm table format in Slack (Type/Email/Status columns) - [ ] Trigger a Security Hub finding — confirm dedup prevents re-alerting, link button opens console - [ ] Wait for Monday 08:00 UTC — confirm weekly summary posts with table - [ ] Test HIGH risk plan — confirm single consolidated alert with findings + override button - [ ] Verify app repos can still plan (OIDC trust policy updated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan-review.ymlintotf-plan.yml— review runs inline after plan in same jobcommit-terraform.ymlandplan-review.ymlplan-review.ymlfrom OIDC trust policyghCLI)Test plan