Harden CI roles: split infra plan/apply, fix registry#46
Merged
Conversation
IAM: - New javabin-ci-infra-plan role: ReadOnlyAccess + scoped writes for state locking, plan upload, Bedrock review, SSM read. Used by plan job. - Restrict javabin-ci-infra trust to refs/heads/main only (not PRs). Previously any PR could assume the full *:* infra role during plan. - Add SSM read (Google SA creds) to javabin-ci-registry role for hero sync. Platform CI: - Plan job now uses javabin-ci-infra-plan (read-only). - Apply job keeps javabin-ci-infra (write, main-only). Registry repo (via gh CLI): - Squash merge only, auto-merge enabled. - Required status check: "Validate Registration".
The role was created via CLI to bootstrap the plan job (chicken-and-egg: the plan job needs the role, but the role is created by the plan). Terraform will import it on first apply. Remove imports.tf after.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewAWS CLI error: LLM returned no structured output. |
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewAWS CLI error: LLM returned no structured output. |
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - Split `javabin-ci-infra` into read-only plan role and write-only apply role - Restrict apply role trust to `refs/heads/main` only (not PRs) - Add SSM read to registry role for hero sync Google credentials - Fix registry repo: squash-only merge, required "Validate Registration" status check ## Test plan - [ ] PR triggers plan job with `javabin-ci-infra-plan` (read-only) — plan succeeds - [ ] Push to main triggers apply job with `javabin-ci-infra` — apply succeeds - [ ] Registry hero sync can read SSM Google SA credentials - [ ] Registry PRs require "Validate Registration" to pass before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javabin-ci-infrainto read-only plan role and write-only apply rolerefs/heads/mainonly (not PRs)Test plan
javabin-ci-infra-plan(read-only) — plan succeedsjavabin-ci-infra— apply succeeds