Pin configure-aws-credentials to v5 for ci-infra role#57
Merged
Conversation
v6 breaks OIDC AssumeRoleWithWebIdentity on the ci-infra role (main-only trust condition). The ci-infra-plan role (any-ref) works fine with v6, so only the apply and drift jobs are pinned back.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟢 LOW Adding a new password-set Lambda function with supporting IAM roles and SSM parameter storage, plus routine updates to existing Lambda functions.
|
Alexanderamiri
added a commit
that referenced
this pull request
Mar 13, 2026
Two issues blocking apply: 1. ci-infra OIDC trust only matched ref-based sub claims, but the apply job uses `environment: production` which sends environment-based claims. Added both formats to the trust condition. 2. password-set IAM role was missing permissions_boundary, which the developer boundary requires for all new roles created via CI. Also reverts v5 pin from #57 since that wasn't the root cause.
1 task
Alexanderamiri
added a commit
that referenced
this pull request
Mar 13, 2026
## Summary - **OIDC trust policy**: apply job uses `environment: production`, which makes GitHub send `repo:javaBin/platform:environment:production` as the sub claim instead of `repo:javaBin/platform:ref:refs/heads/main`. Added both formats. - **Permissions boundary**: `javabin-password-set` role needs `permissions_boundary` — the developer boundary blocks creating roles without it. - **Reverts v5 pin**: #57 pinned credentials to v5, but v5 vs v6 wasn't the issue — it was the sub claim mismatch. ## Test plan - [ ] Apply succeeds — creates password-set Lambda + role + function URL
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - v6 of `aws-actions/configure-aws-credentials` breaks OIDC `AssumeRoleWithWebIdentity` on the `javabin-ci-infra` role (main-only trust condition) - The `ci-infra-plan` role (any-ref trust) works fine with v6, so only the apply and drift detection jobs are pinned back to v5 - This unblocks the apply that failed for PR #56 ## Test plan - [ ] Merge → apply job succeeds with v5
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - **OIDC trust policy**: apply job uses `environment: production`, which makes GitHub send `repo:javaBin/platform:environment:production` as the sub claim instead of `repo:javaBin/platform:ref:refs/heads/main`. Added both formats. - **Permissions boundary**: `javabin-password-set` role needs `permissions_boundary` — the developer boundary blocks creating roles without it. - **Reverts v5 pin**: #57 pinned credentials to v5, but v5 vs v6 wasn't the issue — it was the sub claim mismatch. ## Test plan - [ ] Apply succeeds — creates password-set Lambda + role + function URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-actions/configure-aws-credentialsbreaks OIDCAssumeRoleWithWebIdentityon thejavabin-ci-infrarole (main-only trust condition)ci-infra-planrole (any-ref trust) works fine with v6, so only the apply and drift detection jobs are pinned back to v5Test plan