Fix EventBridge rules: prefix matching instead of hardcoded event names#60
Merged
Conversation
… names CloudTrail event names include version suffixes (e.g. CreateFunction20150331, DeleteFunction20150331) which didn't match the hardcoded names. Using prefix matching (Create*, Delete*, Modify*, etc.) scoped by source service catches all variants without maintaining explicit lists. Fixes missing Slack alerts for Lambda creation/deletion and other resources.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🔴 HIGH Plan creates public unauthenticated access to password-set Lambda function, exposing a sensitive credential management endpoint to the internet.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
…es (#60) ## Summary CloudTrail event names include version suffixes (e.g. `CreateFunction20150331`) that didn't match the hardcoded names in EventBridge rules. This is why resource creation/deletion alerts were never firing for Lambda (and potentially other services). Changed all EventBridge rules to use prefix matching scoped by source service: - **Resource creation**: `Create*`, `Run*` from s3/ec2/rds/ecs/elb/lambda/sqs/dynamodb - **Resource modification/deletion**: `Modify*`, `Update*`, `Delete*`, `Stop*`, `Terminate*` - **IAM changes**: `Create*`, `Delete*`, `Put*`, `Attach*`, `Detach*` from iam - **Compliance reporter**: `Create*`, `Run*` from s3/ec2/rds/ecs/elb/lambda ## Test plan - [ ] After apply, create a test resource (e.g. SQS queue) → Slack alert appears - [ ] Delete test resource → Slack alert appears
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudTrail event names include version suffixes (e.g.
CreateFunction20150331) that didn't match the hardcoded names in EventBridge rules. This is why resource creation/deletion alerts were never firing for Lambda (and potentially other services).Changed all EventBridge rules to use prefix matching scoped by source service:
Create*,Run*from s3/ec2/rds/ecs/elb/lambda/sqs/dynamodbModify*,Update*,Delete*,Stop*,Terminate*Create*,Delete*,Put*,Attach*,Detach*from iamCreate*,Run*from s3/ec2/rds/ecs/elb/lambdaTest plan