Manage function URL permission in Terraform via import#65
Merged
Conversation
The function URL auto-creates this permission on initial creation but doesn't recreate it if deleted. Managing it in Terraform with an import block ensures it stays in sync. Import block should be removed after first successful apply.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟡 MEDIUM Importing an existing Lambda permission that allows public unauthenticated access to the password-set function via function URL.
|
Alexanderamiri
added a commit
that referenced
this pull request
Mar 14, 2026
- Remove imports.tf (one-time import applied successfully in #65) - Update CLAUDE.md: team provisioner is fully implemented (not stubs), add password-set Lambda to function listings
Alexanderamiri
added a commit
that referenced
this pull request
Mar 14, 2026
- Remove imports.tf (one-time import applied successfully in #65) - Update CLAUDE.md: team provisioner is fully implemented (not stubs), add password-set Lambda to function listings
Alexanderamiri
added a commit
that referenced
this pull request
Mar 14, 2026
## Summary - Remove `imports.tf` — the one-time import from #65 applied successfully - Update CLAUDE.md: team provisioner Cognito/Identity Center sync are fully implemented (not stubs), add password-set Lambda to listings No infra changes.
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary The `FunctionURLAllowPublicAccess` permission is auto-created by AWS on function URL creation but doesn't survive deletion. It was removed during debugging and re-added via CLI — creating drift. This PR adds the permission to Terraform with an `import` block to adopt the existing one. The import block should be removed after first successful apply. ## Test plan - [ ] Apply imports the permission (no create/destroy) - [ ] Function URL works after apply - [ ] No drift on subsequent plan
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - Remove `imports.tf` — the one-time import from #65 applied successfully - Update CLAUDE.md: team provisioner Cognito/Identity Center sync are fully implemented (not stubs), add password-set Lambda to listings No infra changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
FunctionURLAllowPublicAccesspermission is auto-created by AWS on function URL creation but doesn't survive deletion. It was removed during debugging and re-added via CLI — creating drift.This PR adds the permission to Terraform with an
importblock to adopt the existing one. The import block should be removed after first successful apply.Test plan