Skip to content

Fix tf-plan step order: checkout platform scripts before broker#87

Merged
Alexanderamiri merged 1 commit into
mainfrom
fix/tf-plan-step-order
Mar 17, 2026
Merged

Fix tf-plan step order: checkout platform scripts before broker#87
Alexanderamiri merged 1 commit into
mainfrom
fix/tf-plan-step-order

Conversation

@Alexanderamiri
Copy link
Copy Markdown
Member

Summary

The broker invocation step (invoke-ci-broker.sh) runs from .platform/scripts/ but the platform checkout happened 3 steps later. This broke app CI when the app repo doesn't have committed TF files (the test app case after deleting old expanded TF).

Moved GitHub App token generation + platform checkout before the OIDC + broker steps.

Test plan

  • Retrigger platform-test-app CI after merge

…ation

The broker step runs invoke-ci-broker.sh from .platform/scripts/ but
the platform checkout happened 3 steps later. Move GitHub App token
generation + platform checkout before the OIDC assumption + broker call.
@Alexanderamiri Alexanderamiri requested a review from a team as a code owner March 17, 2026 22:37
@Alexanderamiri Alexanderamiri enabled auto-merge (squash) March 17, 2026 22:38
@github-actions
Copy link
Copy Markdown

Terraform Plan

No changes — infrastructure is up to date.

Plan output

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

@Alexanderamiri Alexanderamiri merged commit 689f327 into main Mar 17, 2026
3 checks passed
@Alexanderamiri Alexanderamiri deleted the fix/tf-plan-step-order branch March 17, 2026 22:38
Alexanderamiri added a commit that referenced this pull request May 9, 2026
## Summary
The broker invocation step (`invoke-ci-broker.sh`) runs from
`.platform/scripts/` but the platform checkout happened 3 steps later.
This broke app CI when the app repo doesn't have committed TF files (the
test app case after deleting old expanded TF).

Moved GitHub App token generation + platform checkout before the OIDC +
broker steps.

## Test plan
- [ ] Retrigger platform-test-app CI after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant