Skip to content

Comments

#10 Angular JS consuming REST services#156

Merged
arun-gupta merged 1 commit intojavaee-samples:masterfrom
blabno:jaxrs-angularjs
Dec 11, 2013
Merged

#10 Angular JS consuming REST services#156
arun-gupta merged 1 commit intojavaee-samples:masterfrom
blabno:jaxrs-angularjs

Conversation

@blabno
Copy link
Contributor

@blabno blabno commented Dec 3, 2013

No description provided.

@arun-gupta
Copy link
Contributor

@bartoszmajsak I'm no JavaScript expert :-) Have you looked at the sample ? OK with PR ?

@kubamarchwicki
Copy link
Contributor

For some clarity and less "vendor" code we can substitute angular.js files (vendor/ folder) with a webjar (http://www.webjars.org/)

<dependency>
    <groupId>org.webjars</groupId>
    <artifactId>angularjs</artifactId>
    <version>1.2.1</version>
</dependency>

As we are talking about Servlet 3.0 compliant servlet - this should easily work (though I haven't tested it in this particular case)

Just my 5cents :-)

@blabno
Copy link
Contributor Author

blabno commented Dec 10, 2013

Interesting but I disagree.
We would not be able to run karma tests and in current setting we can.
10 gru 2013 18:31 "Kuba Marchwicki" notifications@github.com napisa³(a):

For some clarity and less "vendor" code we can substitute angular.js files
(vendor/ folder) with a webjar (http://www.webjars.org/)

org.webjars angularjs 1.2.1

As we are talking about Servlet 3.0 compliant servlet - this should easily
work (though I haven't tested it in this particular case)

Just my 5cents :-)

Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-30249026
.

@arun-gupta
Copy link
Contributor

@blabno Seems like I waited too long to merge this PR and its causing conflicts now. Can you take a look ?

@bartoszmajsak
Copy link
Contributor

I will be ready with initial APE/Spock stuff by tomorrow evening (spent last few days or Arquillian Forge plung) so Bernard would be able to incorporate APE bits. Does it sound good?

With regards to webjars - that's neat idea in general, but I'm not really convinced how much it will bring in here. Not to mention karma stuff which @blabno has already pointed out.

@arun-gupta if you don't mind giving me push rights I can help you maintaining this repo.

@blabno
Copy link
Contributor Author

blabno commented Dec 11, 2013

Sounds great to me. @bartoszmajsak could you make sure APE works with no datasource inside persistence.xml?
Right no it throws

java.lang.NullPointerException
    at org.jboss.arquillian.persistence.core.configuration.PersistenceDescriptorParser.obtainDataSourceName(PersistenceDescriptorParser.java:61)

@bartoszmajsak
Copy link
Contributor

I'm on it.

arun-gupta added a commit that referenced this pull request Dec 11, 2013
#10 Angular JS consuming REST services
@arun-gupta arun-gupta merged commit 7be2ecf into javaee-samples:master Dec 11, 2013
@arun-gupta
Copy link
Contributor

@blabno blabno deleted the jaxrs-angularjs branch December 15, 2013 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants