Skip to content
This repository was archived by the owner on Nov 15, 2022. It is now read-only.

Fixes 22122 : Updated AppClientScanner to scan annotations even for POJOs#22127

Merged
yaminikb merged 2 commits intojavaee:masterfrom
saxenaks:Iss_22122
Aug 4, 2017
Merged

Fixes 22122 : Updated AppClientScanner to scan annotations even for POJOs#22127
yaminikb merged 2 commits intojavaee:masterfrom
saxenaks:Iss_22122

Conversation

@saxenaks
Copy link
Copy Markdown
Member

Fixes #22122
Earlier in AppClientScanner, annotations are processed if and only if there are managed beans in the bundle. I have disabled that check for presence of managed bean such that annotations are processed in all cases.

@saxenaks saxenaks requested a review from honghzzhang July 28, 2017 07:34
@saxenaks
Copy link
Copy Markdown
Member Author

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Copy Markdown
Contributor

One or more CI tests failed

Copy link
Copy Markdown
Collaborator

@honghzzhang honghzzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok to me. But I noticed the CI test run failed, so there might be something missing that we are not aware of yet. Please look into the test failure and send updated changes for review once you resolve the test failures.

…. This is required as ejb classes contains annotations and they are processed at the time of deployment which results in deployment failure
@saxenaks
Copy link
Copy Markdown
Member Author

saxenaks commented Aug 2, 2017

@glassfishrobot Run CI tests please

@mskdeepak-oracle
Copy link
Copy Markdown
Member

@glassfishrobot Run CI Tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Copy Markdown
Contributor

All CI tests successful

@glassfishrobot
Copy link
Copy Markdown
Contributor

Review needed from GlassFish team members

@glassfishrobot
Copy link
Copy Markdown
Contributor

Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants