This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Enabling disabled test after adding the flag -Ddeployment.resource.va…#22146
Merged
yaminikb merged 11 commits intojavaee:masterfrom Aug 3, 2017
Merged
Enabling disabled test after adding the flag -Ddeployment.resource.va…#22146yaminikb merged 11 commits intojavaee:masterfrom
yaminikb merged 11 commits intojavaee:masterfrom
Conversation
Contributor
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
One or more CI tests failed |
Contributor
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
One or more CI tests failed |
Contributor
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
One or more CI tests failed |
Contributor
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
All CI tests successful |
Member
|
I think you should also be adding a delete-jvm-option in each of these tests at the end. Otherwise, the jvm option will switch off resource validation for other tests also. |
Contributor
Author
|
It's added at the end of group so might not be an issue. But added enabling code now. |
Contributor
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
All CI tests successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #22145 - enabling tests