Skip to content
This repository was archived by the owner on Nov 15, 2022. It is now read-only.

Fixes #22157 : Disable autocomplete in console pages.#22158

Merged
yaminikb merged 8 commits intojavaee:masterfrom
sumauppa:sec_autocomplete
Aug 8, 2017
Merged

Fixes #22157 : Disable autocomplete in console pages.#22158
yaminikb merged 8 commits intojavaee:masterfrom
sumauppa:sec_autocomplete

Conversation

@sumauppa
Copy link
Copy Markdown
Collaborator

@sumauppa sumauppa commented Aug 2, 2017

Fixes #22157 : Disable autocomplete in console pages.
Ran quicklook and console dev tests.

Console dev tests summary:


Tests run: 115, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:21 h
[INFO] Finished at: 2017-08-02T00:18:38-07:00
[INFO] Final Memory: 39M/211M

@sumauppa sumauppa self-assigned this Aug 2, 2017
@sumauppa sumauppa requested review from anissalam and yaminikb August 2, 2017 13:00
@sumauppa
Copy link
Copy Markdown
Collaborator Author

sumauppa commented Aug 2, 2017

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

anissalam
anissalam previously approved these changes Aug 2, 2017
@glassfishrobot
Copy link
Copy Markdown
Contributor

One or more CI tests failed

@sumauppa
Copy link
Copy Markdown
Collaborator Author

sumauppa commented Aug 3, 2017

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Copy Markdown
Contributor

Review needed from GlassFish team members

@glassfishrobot
Copy link
Copy Markdown
Contributor

Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already.

@glassfishrobot
Copy link
Copy Markdown
Contributor

One or more CI tests failed

@sumauppa
Copy link
Copy Markdown
Collaborator Author

sumauppa commented Aug 4, 2017

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Copy Markdown
Contributor

One or more CI tests failed

@sumauppa
Copy link
Copy Markdown
Collaborator Author

sumauppa commented Aug 7, 2017

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Copy Markdown
Contributor

Starting CI tests run

@sumauppa
Copy link
Copy Markdown
Collaborator Author

sumauppa commented Aug 7, 2017

Results :

Tests run: 116, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:15 h
[INFO] Finished at: 2017-08-07T00:08:02-07:00
[INFO] Final Memory: 40M/213M
[INFO] --------------------------

@glassfishrobot
Copy link
Copy Markdown
Contributor

All CI tests successful

Copy link
Copy Markdown
Member

@anissalam anissalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this, but please update the bug report with some info about the fix. Why is the need of adding the 'name' field, so others can understand the change.

@yaminikb yaminikb merged commit a19298c into javaee:master Aug 8, 2017
@sumauppa sumauppa deleted the sec_autocomplete branch August 9, 2017 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants