This repository was archived by the owner on Nov 15, 2022. It is now read-only.
fix #22216: WEBSOCKET - CDI RELATED TESTS FAIL IN CTS#22210
Merged
yaminikb merged 1 commit intojavaee:masterfrom Aug 16, 2017
Merged
fix #22216: WEBSOCKET - CDI RELATED TESTS FAIL IN CTS#22210yaminikb merged 1 commit intojavaee:masterfrom
yaminikb merged 1 commit intojavaee:masterfrom
Conversation
Member
Author
|
@glassfishrobot Run CI tests please |
Contributor
|
Starting CI tests run |
Contributor
|
All CI tests successful |
jjsnyder
approved these changes
Aug 15, 2017
Collaborator
jjsnyder
left a comment
jjsnyder
left a comment
There was a problem hiding this comment.
The changes seem fine to me but I know very little about the web container. Someone with more knowledge of the web container and how the events work should probably take a look too.
Member
Author
|
The events fired correspond to preInvoke et al as described in the bug comments. |
shingwaichan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.