Fixes #22246: Licence update#22220
Fixes #22246: Licence update#22220yaminikb merged 9 commits intojavaee:masterfrom arindam-bandyopadhyay:licence-update
Conversation
yaminikb
left a comment
yaminikb
left a comment
There was a problem hiding this comment.
I haven't looked at the web profile one.
| Weld 3.0.0.Final | ||
| Hibernate Validator 6.0.1.Final | ||
| Classmate 1.3.3 | ||
| IBM Batch |
| jackson 1.9.2 | ||
| jrebel 3.1.2 SDK | ||
| Velocity 1.4 | ||
| Google-collections guava 13.0.1 |
There was a problem hiding this comment.
Remove guava since its just a test dependency
| required by the LGPL. If you do not delete the provisions above, a recipient may use your version of this | ||
| file under the terms of either the MPL or the LGPL. | ||
|
|
||
| --------------------------------------------------- |
There was a problem hiding this comment.
SL4J dependency exists. Version 1.7.21
Also, add this to the list on top
|
|
||
| DEALINGS IN THE SOFTWARE. | ||
|
|
||
| --------------------------------------------------- |
There was a problem hiding this comment.
We are updating to libpam4j 1.8
Also add this to list on top
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
|
|
||
| --------------------------------------------------- |
There was a problem hiding this comment.
This needs to be retained. This dependency is used for configuring Windows as a service
|
|
||
| permission. | ||
|
|
||
| --------------------------------------------------- |
There was a problem hiding this comment.
We are packaging Dojo Toolkit in the admin console app though I'm unable to extract the exact version info from the contents of the jar. The jar says 0.4.1
|
|
||
| --------------------------------------------------- | ||
|
|
||
| J-Interop 2.0.8 |
There was a problem hiding this comment.
Can be removed, we are not packaging this
| -------------------------------------------------------- | ||
|
|
||
| jarapac 0.3.8 | ||
| ------------------------------------------------------ |
There was a problem hiding this comment.
Can be removed, we are not packaging this
| - web-fragment_3_1.xsd | ||
|
|
||
| may be obtained from: | ||
| http://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html |
There was a problem hiding this comment.
I think the following dependencies are missed out:
Yasson 1.0
commons-io 2.5
Dependency Injection 1.0
stax2 3.1.4
jboss-classfilewriter 1.2.1Final
trilead-ssh2 build212-hudson-6
jboss-logging 3.3.1Final
arindam-bandyopadhyay
dismissed
yaminikb’s stale review
incorporated review comments
|
@glassfishrobot Run CI tests please |
|
Starting CI tests run |
|
All CI tests successful |
|
@glassfishrobot Run CI tests please |
|
Starting CI tests run |
|
All CI tests successful |
| @@ -1,4 +1,4 @@ | |||
| GlassFish Server_4.0_THIRDPARTYLICENSEREADME.txt | |||
| GlassFish Server_5.0_THIRDPARTYLICENSEREADME.txt | |||
There was a problem hiding this comment.
Please change this line to look like this:
GlassFish Server 5.0 3RD-PARTY-LICENSE.txt
| IBM Batch | ||
| Derby 10.13.1.1 | ||
| Weld 3.0.0.Final | ||
| Hibernate Validator 6.0.1.Final |
There was a problem hiding this comment.
We updated to 6.0.2.Final last week.
| @@ -1,4 +1,4 @@ | |||
| GlassFish Server 4.0 Web Profile THIRDPARTYLICENSEREADME.txt | |||
| GlassFish Server 5.0 Web Profile THIRDPARTYLICENSEREADME.txt | |||
There was a problem hiding this comment.
Please change this as:
GlassFish Server 5.0 Web Profile 3RD-PARTY-LICENSE-WEB-PROFILE.txt
arindam-bandyopadhyay
dismissed
yaminikb’s stale review
review comments incorporated
3 participants
Fixes #22246